Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Document that icu is a new, optional native dependency #14704

Closed

Description

@anoadragon453

#14464 added icu as a new, optional native dependency to improve user directory search for non-English languages. If the python module is installed, then the new user search code is used, otherwise it will fall back to the old code.

We should:

  1. Update our installation instructions for native dependencies to include icu / libicu-dev.
  2. Update the UPGRADE notes to mention the new dependency. (This is the release blocker)
  3. Update the Contributing Guide to mention installing icu / libicu-dev, otherwise poetry install --extras all will fail to install pyicu.

Activity

  1. clokep commented on Dec 19, 2022

    @clokep
    Member
  2. added
    T-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
    on Dec 19, 2022
  3. self-assigned this
    on Dec 20, 2022
  4. added a commit that references this issue on Dec 20, 2022
    eb2defc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-Docsthings relating to the documentationT-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.X-Release-BlockerMust be resolved before making a release

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions