Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Run Sytest and Complement with the Twisted asyncioreactor enabled in CI #14091

Open

Description

@sandhose

I'd like to start running the test suites with the asyncioreactor enabled to see what breaks. This issue tracks the changes in Synapse, Sytest and Complement to achieve this.

Related: #8642, #12135

I opened a few PRs:

Activity

  1. added
    T-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
    on Oct 7, 2022
  2. realtyem commented on Oct 14, 2022

    @realtyem
    Contributor

    Not sure if it's welcome(or relevant) but when I enable this and SYNAPSE_USE_EXPERIMENTAL_FORKING_LAUNCHER at the same time, I get this:

    Traceback (most recent call last):
      File "/usr/local/lib/python3.10/runpy.py", line 196, in _run_module_as_main
        return _run_code(code, main_globals, None,
      File "/usr/local/lib/python3.10/runpy.py", line 86, in _run_code
        exec(code, run_globals)
      File "/usr/local/lib/python3.10/site-packages/synapse/app/complement_fork_starter.py", line 218, in <module>
        main()
      File "/usr/local/lib/python3.10/site-packages/synapse/app/complement_fork_starter.py", line 152, in main
        installReactor(proxy_reactor)
      File "/usr/local/lib/python3.10/site-packages/twisted/internet/main.py", line 32, in installReactor
        raise error.ReactorAlreadyInstalledError("reactor already installed")
    twisted.internet.error.ReactorAlreadyInstalledError: reactor already installed
    
  3. DMRobertson commented on Oct 14, 2022

    @DMRobertson
    Contributor

    This is both welcome and relevant. It needs discussing on #14099.

  4. added
    A-TestingIssues related to testing in complement, synapse, etc
    A-CIIssues related to CI on the Synapse repository
    on Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-CIIssues related to CI on the Synapse repositoryA-TestingIssues related to testing in complement, synapse, etcT-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions