Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

conf/workers-shared-extra.yaml.j2 is applied to monolith Complement runs #13590

Open
Open
conf/workers-shared-extra.yaml.j2 is applied to monolith Complement runs#13590
Labels
A-TestingIssues related to testing in complement, synapse, etcO-OccasionalAffects or can be seen by some users regularly or most users rarelyS-TolerableMinor significance, cosmetic issues, low or no impact to users.T-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Description

@MadLittleMods
MadLittleMods
opened on Aug 23, 2022

docker/complement/conf/workers-shared-extra.yaml.j2 seems to apply even when SYNAPSE_COMPLEMENT_USE_WORKERS=true isn't set. I assume they aren't supposed to stack like that for the monolith?

Noticed because I saw the reject_limit as 99999 when investigating #13541 (comment). Disabling the rate limit could be as expected for the monolith but the way it's inherited from workers seems weird.

This is the command I was running for reference but it probably works in the simplified case as well,

TEST_ONLY_IGNORE_POETRY_LOCKFILE=1 TEST_ONLY_SKIP_DEP_HASH_VERIFICATION=1 COMPLEMENT_DEBUG=1 COMPLEMENT_KEEP_BLUEPRINTS="fed.perf_many_messages.hs1" COMPLEMENT_ALWAYS_PRINT_SERVER_LOGS=1 COMPLEMENT_DIR=../complement ./scripts-dev/complement.sh -run TestMessagesOverFederation -p 1

Dev notes

Related PRs:

Activity

  1. MadLittleMods
    added
    z-testing
    on Aug 23, 2022
  2. DMRobertson
    added
    T-OtherQuestions, user support, anything else.
    on Aug 23, 2022

  3. DMRobertson commented on Aug 23, 2022

    @DMRobertson
    DMRobertson
    on Aug 23, 2022
    Contributor

    Don't have much familiarity here. @reivilibre might be able to advise?

  4. H-Shay
    added
    O-OccasionalAffects or can be seen by some users regularly or most users rarely
    S-TolerableMinor significance, cosmetic issues, low or no impact to users.
    T-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
    and removed
    T-OtherQuestions, user support, anything else.
    on Aug 24, 2022

  5. H-Shay commented on Aug 24, 2022

    @H-Shay
    H-Shay
    on Aug 24, 2022
    Contributor

    Marking this as occasional as it doesn't occur on all runs, and tolerable as it seems that there is a workaround.

  6. richvdh commented on Aug 25, 2022

    @richvdh
    richvdh
    on Aug 25, 2022
    Member

    I assume they aren't supposed to stack like that for the monolith?

    No, I think this is expected behaviour. As the first two lines in the file say:

    This file extends the default 'shared' configuration file (from the 'synapse-workers'
    docker image) with Complement-specific tweak.

    I think it's just ended up with a bit of a misleading name, so the solution here is just to rename it?

  7. richvdh
    added
    A-TestingIssues related to testing in complement, synapse, etc
    and removed
    z-testing
    on Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-TestingIssues related to testing in complement, synapse, etcO-OccasionalAffects or can be seen by some users regularly or most users rarelyS-TolerableMinor significance, cosmetic issues, low or no impact to users.T-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions