Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Trace details of the concurrent calls within _check_sigs_and_hash_and_fetch #13587

Closed
#13588
Closed
Trace details of the concurrent calls within _check_sigs_and_hash_and_fetch#13587
#13588
Assignees
MadLittleMods
Labels
A-Messages-Endpoint/messages client API endpoint (`RoomMessageListRestServlet`) (which also triggers /backfill)T-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Description

@MadLittleMods
MadLittleMods
opened on Aug 22, 2022

Trace details of the concurrent calls within _check_sigs_and_hash_and_fetch.

You can see that we're missing where all of the time went in this /messages trace while backfilling (_check_sigs_and_hash_and_fetch took 10.41s, only processing 100 events):

Breakdown of child spans in _check_sigs_and_hash_and_fetch in a Jaeger trace

More of the trace for context:

_check_sigs_and_hash_and_fetch taking 10s in a Jaeger trace

Activity

  1. MadLittleMods
    added
    T-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
    A-Messages-Endpoint/messages client API endpoint (`RoomMessageListRestServlet`) (which also triggers /backfill)
    on Aug 22, 2022
  2. MadLittleMods
    self-assigned this
    on Aug 22, 2022
  3. MadLittleMods
    added a commit that references this issue on Aug 22, 2022

    Trace time in _check_sigs_and_hash_and_fetch

    28fb5d0
  4. MadLittleMods
    closed this as completedin #13588on Aug 24, 2022
  5. MadLittleMods
    added a commit that references this issue on Aug 24, 2022

    Instrument `_check_sigs_and_hash_and_fetch` to trace time spent in ch…

    7af07f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-Messages-Endpoint/messages client API endpoint (`RoomMessageListRestServlet`) (which also triggers /backfill)T-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions