Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Faster joins: handle incoming federated join requests during a faster join #13290

Closed

Description

@richvdh

If we get an incoming send_join during a faster-join resync, I think that we will reply with incomplete results. (Either an incomplete server list if it's a faster-join request, or incomplete state list if not.)

Activity

  1. changed the title [-]Faster joins: handle join requests during a faster join[/-] [+]Faster joins: handle incoming federated join requests during a faster join[/+] on Jul 15, 2022
  2. added
    A-Federated-Joinjoins over federation generally suck
    T-DefectBugs, crashes, hangs, security vulnerabilities, or other reported issues.
    on Jul 15, 2022
  3. richvdh commented on Jul 28, 2022

    @richvdh
    MemberAuthor

    In this situation, I think we should behave the same way we would if we were not in the room at all, which is (currently) to reject it with a 404.

  4. self-assigned this
    on Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-Federated-Joinjoins over federation generally suckT-DefectBugs, crashes, hangs, security vulnerabilities, or other reported issues.

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions