Faster joins: stuck "partial state room" if persisting the /send_join response fails #12998

Activity

1. richvdh

   added this to the Q2 2022 ─ Faster joins phase 2: correctness milestone on Jun 9, 2022
2. richvdh

   added

   A-Federated-Joinjoins over federation generally suckjoins over federation generally suck

   T-DefectBugs, crashes, hangs, security vulnerabilities, or other reported issues.Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

   on Jun 9, 2022
3. richvdh commented on Jun 9, 2022

   

   richvdh

   on Jun 9, 2022

   Last edited by richvdh

   MemberAuthor

   More actions

   synapse/synapse/handlers/federation.py

   Lines 545 to 549 in 7c6b220

   	if ret.partial_state:
   	# TODO(faster_joins): roll this back if we don't manage to start the
   	# background resync (eg process_remote_join fails)
   	# https://github.com/matrix-org/synapse/issues/12998
   	await self.store.store_partial_state_room(room_id, ret.servers_in_room)
4. richvdh

   modified the milestones: Q2 2022 ─ Faster joins phase 2: correctness, Q3 2022: Faster joins: fix major known bugs for monoliths on Jul 20, 2022
5. richvdh commented on Jul 22, 2022

   

   richvdh

   on Jul 22, 2022

   MemberAuthor

   More actions

   I think this is relatively low-hanging fruit which someone could pick up without too much introduction
6. reivilibre

   self-assigned this

   on Jul 27, 2022
7. reivilibre

   closed this as completedin #13403on Aug 1, 2022