You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Repository navigation
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Faster joins: check how incoming events are authed during the partial-state phase #12644
I/we need to revisit how incoming events are authed while we lack full state. When I was testing, it looked like we were relying on Synapse's unspecced _update_auth_events_for_auth behaviour. If we're going to rely on that, we'll have to understand it and spec it.
A subtask of this is to figure out if we need power events upfront (eg, banned users) to get reliable state.
Did we not decide that we should try ripping the _update_auth_events_for_auth code out?
We talked about it back in a previous tranche of event-auth work (see #9595 (comment) etc), but I think we decided we needed to convince ourselves it wasn't important, first. The work for #9595 ended up significantly simplifying it, and documenting its interface a bit, but never got as far as completely ripping it out.
The problem we have now is that the faster-joins work appears to be relying on _update_auth_events_for_auth, so we now need to re-consider whether we still want to rip it out, or do something else for faster-joins.
Activity
erikjohnston commentedon May 10, 2022
Did we not decide that we should try ripping the
_update_auth_events_for_authcode out?richvdh commentedon May 16, 2022
We talked about it back in a previous tranche of event-auth work (see #9595 (comment) etc), but I think we decided we needed to convince ourselves it wasn't important, first. The work for #9595 ended up significantly simplifying it, and documenting its interface a bit, but never got as far as completely ripping it out.
The problem we have now is that the faster-joins work appears to be relying on
_update_auth_events_for_auth, so we now need to re-consider whether we still want to rip it out, or do something else for faster-joins.