Olddeps job is running against Python 3.8, but our oldest supported is 3.7 #12343

Activity

1. DMRobertson

   added

   T-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

   on Mar 31, 2022
2. DMRobertson commented on Apr 1, 2022

   

   DMRobertson

   on Apr 1, 2022

   ContributorAuthor

   More actions

   Is there any particular reason that olddeps is tied to a particular Debian/Ubuntu distribution? What's there to stop us from using actions/setup-python with version: 3.7? I guess we wouldn't have older libcs...

   Oh, it's the old postgres version we want. Hmm.
3. richvdh commented on Apr 5, 2022

   

   richvdh

   on Apr 5, 2022

   Member

   More actions

   for context, this change happened in #12343. It's not obvious to me if we realised that this would bring Python 3.8 at the time.

   That said, we do have separate test runs for Python 3.7, so it's not necessarily a large problem.
4. richvdh commented on Apr 5, 2022

   

   richvdh

   on Apr 5, 2022

   Member

   More actions

   Oh, it's the old postgres version we want. Hmm.

   I'm not sure it is. We have a separate test job for python 3.7 and postgres 10.
5. DMRobertson

   linked a pull request that will close this issueUpdate trial old deps CI to use poetry 1.2.0 #13707on Sep 6, 2022
6. DMRobertson commented on Sep 6, 2022

   

   DMRobertson

   on Sep 6, 2022

   ContributorAuthor

   More actions

   Fixed as a drive-by in #13707, thanks Erik!
7. DMRobertson

   closed this as completedon Sep 6, 2022