Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Synapse responds with a 404 with HTML content for unknown URL prefixes #11600

Description

@clokep

See element-hq/element-web#19738 (comment) for some background, but if you request an endpoint for Synapse that doesn't have a prefix registered (see here) then Synapse responds with a 404 including HTML content (the default Twisted 404 handler).

This wasn't an issue when adding new /unstable or /r0 endpoints since the prefix was registered, but the /hierarchy endpoint is the first /v1 endpoint we had. This will also bite us once we need to rev an endpoint to /v2 (or /v4) since neither of those are registered right now.

Activity

  1. added
    S-MinorBlocks non-critical functionality, workarounds exist.
    T-DefectBugs, crashes, hangs, security vulnerabilities, or other reported issues.
    on Dec 17, 2021
  2. t3chguy commented on Dec 17, 2021

    @t3chguy
    Member

    then Synapse responds with a 404 including HTML content (the default Twisted 404 handler).

    and without an ACAO header so browser-based clients can't even read that its a 404 as the browser just gives them a generic failure due to CORS.

  3. self-assigned this
    on Dec 17, 2021
  4. clokep commented on Jan 18, 2022

    @clokep
    MemberAuthor

    This was reverted due to poor interaction with a legacy feature.

  5. reopened this on Jan 18, 2022
  6. clokep commented on Oct 14, 2022

    @clokep
    MemberAuthor

    Cross-ref to a similar Dendrite issue: matrix-org/dendrite#2739.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

S-MinorBlocks non-critical functionality, workarounds exist.T-DefectBugs, crashes, hangs, security vulnerabilities, or other reported issues.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions