Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

require Collections rather than Iterables in storage functions #11569

Closed

Description

@richvdh

There are various methods in DatabasePool (such as simple_insert_many_values) which claim to take arbitrary Iterables as arguments when in fact they cannot be generators (since they may be evaluated more than once: see #11564).

We should change their definitions to Collection.

Activity

  1. richvdh commented on Dec 13, 2021

    @richvdh
    MemberAuthor

    (note: this does not generally apply to _txn variants, because they do not pass their arguments to runInteraction and hence do not evaluate them multiple times.)

  2. added
    T-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
    on Dec 14, 2021
  3. self-assigned this
    on Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

T-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions