Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Unexpected AuthError from _check_event_auth #11513

Closed

Description

@richvdh

#11011 added a check, boldly asserting that some code was unreachable. The evidence suggests otherwise. We should find out why this is happening.

Activity

  1. richvdh commented on Dec 6, 2021

    @richvdh
    MemberAuthor

    Example stacktrace:

    AuthError: 403: Auth events could not be found
      File "synapse/handlers/federation_event.py", line 983, in _process_received_pdu
        context,
      File "synapse/handlers/federation_event.py", line 1371, in _check_event_auth
        origin, event
      File "synapse/handlers/federation_event.py", line 1683, in _load_or_fetch_auth_events_for_event
        raise AuthError(code=HTTPStatus.FORBIDDEN, msg="Auth events could not be found")
    

    https://sentry.matrix.org/sentry/synapse-matrixorg/issues/233645
    https://sentry.matrix.org/sentry/synapse-modular/issues/235420

  2. added
    T-DefectBugs, crashes, hangs, security vulnerabilities, or other reported issues.
    on Dec 8, 2021
  3. richvdh commented on Jun 30, 2022

    @richvdh
    MemberAuthor

    #11001 made AuthError a documented exception from _check_event_auth, so the problem is now simply that we log it. Fixed by #13145.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-DefectBugs, crashes, hangs, security vulnerabilities, or other reported issues.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions