Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

'apparently some people use access tokens that are not macaroons' #10964

Closed
#12577
Closed
'apparently some people use access tokens that are not macaroons'#10964
#12577
Assignees
reivilibre
Labels
T-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Description

@reivilibre
reivilibre
opened on Oct 1, 2021

This comment seems stale, since it now seems like we encourage and use syt_... tokens by default which are not macaroons?

synapse/synapse/api/auth.py

Lines 417 to 418 in 8c7a531

# TODO: it would be nice to get rid of this, but apparently some
# people use access tokens which aren't macaroons

Activity

  1. reivilibre
    added
    T-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
    on Oct 1, 2021
  2. reivilibre
    self-assigned this
    on Oct 1, 2021

  3. richvdh commented on Oct 1, 2021

    @richvdh
    richvdh
    on Oct 1, 2021
    Member

    yes it is. That comment dates from a period where we were trying to move away from random strings as access tokens, towards macaroons. We've long since aborted that plan.

  4. reivilibre
    closed this as completedin #12577on May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

T-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions