Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Update spaces summary to use join rules, not history visibility #10255

Closed
#10298
Closed
Update spaces summary to use join rules, not history visibility#10255
#10298
Assignees
clokep
Labels
T-EnhancementNew features, changes in functionality, improvements in performance, or user-facing enhancements.

Description

@clokep
clokep
opened on Jun 25, 2021

Now that MSC3173 has merged we've updated MSC2946 to mention that join rules, not history visibility, should be used when returning results in the spaces summary.

We need to update the spaces summary to include any rooms that are joinable as opposed to those with world readable history visibility.

Activity

  1. clokep
    added
    T-EnhancementNew features, changes in functionality, improvements in performance, or user-facing enhancements.
    on Jun 25, 2021
  2. clokep
    self-assigned this
    on Jun 25, 2021

  3. clokep commented on Jun 25, 2021

    @clokep
    clokep
    on Jun 25, 2021
    MemberAuthor

    This should mostly involve messing with the SpaceSummaryHandler._is_room_accessible method.

  4. clokep commented on Jul 1, 2021

    @clokep
    clokep
    on Jul 1, 2021
    MemberAuthor

    #10298 should fix this.

  5. clokep
    closed this as completedin #10298on Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

T-EnhancementNew features, changes in functionality, improvements in performance, or user-facing enhancements.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions