Repository navigation
Conversation
Signed-off-by: Dan Callahan <danc@element.io>
Signed-off-by: Dan Callahan <danc@element.io>
Signed-off-by: Dan Callahan <danc@element.io>
Signed-off-by: Dan Callahan <danc@element.io>
anoadragon453
left a comment
anoadragon453
left a comment
There was a problem hiding this comment.
lgtm generally, just a few things. Yay for trying out Poetry on one of our projects!
anoadragon453
left a comment
anoadragon453
left a comment
There was a problem hiding this comment.
Thanks for the responses, looks good to me then. Looking forward to trying poetry out when it comes to the more developmentally-active repositories 🙂
|
One concern: Apparently support for minimum Python versions only landed in Pip 9 (2016-11-02) and Setuptools 24.2.0 (2016-07-20). Even Debian Stretch has these versions... but Ubuntu Xenial doesn't. Given that Xenial is EOL and drops security updates in less than a month, I'm personally comfortable moving ahead with this. |
|
Can we split this into separate PRs that do various bits? E.g. I don't like burying the reformatting with black into a PR about packaging (especially if we squash merge this we then can't ignore the commit for git blame). |
|
Would you be comfortable with a rebase and merge? Each commit is pretty self-contained as is. |
Signed-off-by: Dan Callahan <danc@element.io>
That should be fine too! 👍 It's just useful to have the reformatting(s) separate! |
|
Awesome. Going for it and publishing updated package to PyPI |
3 participants
Fixes #4
Uses Poetry instead of setuptools