Repository navigation
Do not require typing_extensions on python 3.8+ - #12
Conversation
|
Reducing dependencies is a good idea, but mypy doesn't seem to like the construct: https://mypy-play.net/?mypy=latest&python=3.10&gist=9ac99f23480e5c8bc86c68f94ce65b6c |
python/mypy#1153 (comment) describes a neater workaround |
edab0fa to
3a9bae6
Compare
|
I am really sorry about the delay, mypy, pylint and flake8 now pass on my changes. |
squahtx
left a comment
squahtx
left a comment
There was a problem hiding this comment.
Thank you for making the changes!
Looks good, just two minor comments.
| 'typing_extensions>=3.5;python_version<"3.8"', | ||
| 'typing>=3.5;python_version<"3.5"', | ||
| 'importlib_metadata;python_version<"3.8"', | ||
| ], |
There was a problem hiding this comment.
I think we always need typing_extensions as a dev dependency now.
| ], | |
| ], | |
| extras_require={ | |
| "dev": ["typing_extensions>=3.5"], | |
| }, |
There was a problem hiding this comment.
Is that because the linters would find an unmet dependency?
There was a problem hiding this comment.
Yes, when running mypy, we'd always use typing_extensions now
3a9bae6 to
3258a36
Compare
squahtx
left a comment
squahtx
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for the PR!
Protocol is a part of typing since python 3.8 https://docs.python.org/3/library/typing.html#typing.Protocol