This repository was archived by the owner on Nov 25, 2022. It is now read-only.
Repository navigation
Synapse: Add step to check for unix file endings - #81
Merged
Merged
Conversation
anoadragon453
force-pushed
the
anoa/synapse_windows_file_endings
branch
from
July 24, 2020 21:26
b21d9b1 to
c38af5f
Compare
richvdh
reviewed
Jul 26, 2020
Member
Author
|
Updated to use the new repo script 🙂 |
anoadragon453
added a commit
to matrix-org/synapse
that referenced
this pull request
Jul 28, 2020
This PRs adds a script to check for unix-line terminators in the repo. It will be used to address #7943 by adding the check to CI. I've changed the original script slightly as proposed in matrix-org/pipelines#81 (comment)
richvdh
approved these changes
Jul 28, 2020
richvdh
left a comment
richvdh
left a comment
Member
There was a problem hiding this comment.
lgtm.
part of me wonders if we should merge some of these lint steps to save spinning up lots of buildkite agents... otoh we're going to need lots of buildkite agents to run the tests so it probably doesn't make much difference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To address matrix-org/synapse#7943. I'm using the
python:3.6image for consistency, but this would probably run onalpine.