feat(ffi): Auto approve the required widget capabilities for element call raise hand and reaction feature. - #4229
Merged
jmartinesp merged 1 commit intoNov 7, 2024
Conversation
toger5
force-pushed
the
toger5/auto-approve-element-call-reaction-and-raise-hand
branch
from
November 6, 2024 18:09
c9b385d to
e564729
Compare
toger5
marked this pull request as ready for review
November 6, 2024 21:13
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4229 +/- ##
==========================================
- Coverage 84.83% 84.82% -0.02%
==========================================
Files 273 273
Lines 29519 29519
==========================================
- Hits 25042 25039 -3
- Misses 4477 4480 +3 ☔ View full report in Codecov by Sentry. |
jmartinesp
approved these changes
Nov 7, 2024
jmartinesp
left a comment
jmartinesp
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just left a question about a comment.
| // version-specific auth rules (namely MSC3779). | ||
| WidgetEventFilter::StateWithType { event_type: StateEventType::RoomCreate.to_string() }, | ||
| ], | ||
| // Custom element call reaction event. (which can be send multiple times for one |
Contributor
There was a problem hiding this comment.
Is this comment correctly placed?
Contributor
Author
There was a problem hiding this comment.
That is an accident thx.
removed it since the same/similar comment is at the right location.
…call raise hand and reaction feature.
toger5
force-pushed
the
toger5/auto-approve-element-call-reaction-and-raise-hand
branch
from
November 7, 2024 08:28
e564729 to
ca99fd1
Compare
jmartinesp
deleted the
toger5/auto-approve-element-call-reaction-and-raise-hand
branch
November 7, 2024 11:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same work as done in:
element-hq/element-web#28401
It also refactors the ffi
get_element_call_required_permissionsfunction to use aread_sendarray that gets copied both (read and send) capability lists.Signed-off-by: