Repository navigation
docs(sdk): Improve read receipt/marker explanation - #1491
Merged
Merged
Conversation
Collaborator
|
Note that I'm actually planning on changing these methods to allow to use all the new possibilities of the spec introduced in Matrix 1.4, so the docs will probably change there too. I'll open a PR later today. |
jplatte
approved these changes
Feb 13, 2023
jplatte
left a comment
jplatte
left a comment
Collaborator
There was a problem hiding this comment.
Future improvements aside, this looks good. Thanks!
Collaborator
|
Oh, since #1490 isn't merged yet CI will fail but that's no problem, I'll take care of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was unclear what the relationship between the read receipt and read marker was, so I copied a bit from https://spec.matrix.org/latest/client-server-api/#fully-read-markers and added hyperlinks between the functions.
Signed-off-by: Enterprisey apersonwiki@gmail.com
See private accepted DCO signoff at matrix-org/synapse#13818 (comment)