Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Update the button styling on the emoji comparison dialog during cross-signing - #6943

Merged
duxovni merged 2 commits into
developfrom
fayed/emoji-compare-buttons
Oct 15, 2021
Merged

duxovni merged 2 commits into
developfrom
fayed/emoji-compare-buttons

Conversation

@duxovni

@duxovni duxovni commented Oct 14, 2021 •

Copy link
Copy Markdown
Contributor

Fixes element-hq/element-web#19289.

Figma from design conversations: https://www.figma.com/file/wwqBo5oAFfk8XKmtd2YaIs/Cross-signing?node-id=7820%3A66509 (See also element-hq/element-web#19290, which I'll make a separate PR for)

Screenshot:
improved-emoji-comparison-buttons


This PR currently has no changelog labels, so will not be included in changelogs.

A reviewer can add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is, or add Type: [enhancement/defect/task] to the description and I'll add them for you.

Preview: https://6167bb35df6d8466f0fba642--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

…-signing

Signed-off-by: Faye Duxovni <fayed@element.io>
@duxovni
duxovni requested a review from a team as a code owner October 14, 2021 05:02

@germain-gg germain-gg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@duxovni
duxovni merged commit 1b7277b into develop Oct 15, 2021
@duxovni
duxovni deleted the fayed/emoji-compare-buttons branch October 15, 2021 14:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the button styling on the emoji comparison dialog

2 participants