Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Fix: make alternative addresses UX less confusing - #4221

Merged
bwindels merged 10 commits into
developfrom
bwindels/aliaslipstick
Mar 17, 2020
Merged

bwindels merged 10 commits into
developfrom
bwindels/aliaslipstick

Conversation

@bwindels

@bwindels bwindels commented Mar 16, 2020 •

Copy link
Copy Markdown
Contributor

@bwindels bwindels changed the title Bwindels/aliaslipstick Fix: make alternative addresses UX less confusing Mar 16, 2020
@bwindels

bwindels commented Mar 16, 2020 •

Copy link
Copy Markdown
Contributor Author

Ahh, the e2ee tests are failing, will fix tomorrow. Build was just cancelled.

@bwindels bwindels added the X-Release-Blocker This affects the current release cycle and must be solved for a release to happen label Mar 16, 2020
@bwindels
bwindels requested a review from a team March 16, 2020 17:31
@bwindels
bwindels requested a review from nadonomy March 17, 2020 09:48

@nadonomy nadonomy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jryans jryans left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, thanks! 😄

Comment thread src/components/views/room_settings/AliasSettings.js Outdated
bwindels and others added 2 commits March 17, 2020 10:43
Co-Authored-By: J. Ryan Stinnett <jryans@gmail.com>
@bwindels
bwindels merged commit e8c7754 into develop Mar 17, 2020
@luixxiul luixxiul mentioned this pull request May 1, 2023
1 of 3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

X-Release-Blocker This affects the current release cycle and must be solved for a release to happen

Projects

None yet

3 participants