Add post-login complete security flow - #3847
Conversation
This adds a step after login to complete security for your new session. At the moment, the only verification method is entering your SSSS passphrase, but nicer paths will be added soon. This new step only appears when crypto is available and the account has cross-signing enabled in SSSS. Fixes element-hq/element-web#11214
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
lgtm overall - does this work okay with soft logout? You can trick Riot into soft logging you out with localStorage.setItem("mx_soft_logout", true); and reloading the page. I wouldn't recommend trying to follow the code to determine if it works - it's probably better for your mental health to just press the buttons.
Co-Authored-By: Travis Ralston <travpc@gmail.com>
Co-Authored-By: Travis Ralston <travpc@gmail.com>
|
Just in case it gets buried in #riot-dev: test failures look legitmate (though the |
|
I have confirmed that soft logout is working for account both with and without SSSS. I cannot reproduce any login issues, but perhaps my changes today have fixed what you saw. @turt2live, can you please retest? |
2 participants
This adds a step after login to complete security for your new session. At the
moment, the only verification method is entering your SSSS passphrase, but nicer
paths will be added soon.
This new step only appears when crypto is available and the account has
cross-signing enabled in SSSS.
Fixes element-hq/element-web#11214
Depends on matrix-org/matrix-js-sdk#1153
Depends on element-hq/element-web#11891