This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Merge end-to-end tests - #3537
Merged
Merged
Conversation
…rt riots that were built by another process
Make tests run on CI environment
…s on dev machines
this assumes the riot-web local dev server is running
bwindels
force-pushed
the
bwindels/merge-e2e-tests
branch
from
October 9, 2019 15:58
465e07e to
2d848bb
Compare
jryans
suggested changes
Oct 18, 2019
| with_riot=1 | ||
|
|
||
| for i in $@; do | ||
| if [ "$i" == "--without-riot" ] ; then |
Collaborator
There was a problem hiding this comment.
It's a bit perplexing to have a "Riot" install script which also takes an option "no Riot"... Maybe it would be easier to follow by moving the HTTP server bit to it's own script?
Then this script can call the new script (so caller of this don't need to change), and end-to-end-tests.sh would only call the HTTP server script.
Co-Authored-By: J. Ryan Stinnett <jryans@gmail.com>
Co-Authored-By: J. Ryan Stinnett <jryans@gmail.com>
Co-Authored-By: J. Ryan Stinnett <jryans@gmail.com>
Co-Authored-By: J. Ryan Stinnett <jryans@gmail.com>
Co-Authored-By: J. Ryan Stinnett <jryans@gmail.com>
Co-Authored-By: J. Ryan Stinnett <jryans@gmail.com>
Co-Authored-By: J. Ryan Stinnett <jryans@gmail.com>
Co-Authored-By: J. Ryan Stinnett <jryans@gmail.com>
Co-Authored-By: J. Ryan Stinnett <jryans@gmail.com>
bwindels
commented
Oct 18, 2019
so we can just do the latter for the e2e tests on CI
jryans
approved these changes
Oct 18, 2019
jryans
left a comment
jryans
left a comment
Collaborator
There was a problem hiding this comment.
Looks great to me, thanks! 😁
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
element-hq/element-web#11101
matrix-org/matrix-react-end-to-end-tests#44
Dear reviewer, I imported the git history from https://github.com/matrix-org/matrix-react-end-to-end-tests to not have a big blob of code we don't know the history off. Please start reviewing at this commit.
Review with element-hq/element-web#11115