Skip to content

Add getMediaLimits to client - #644

Merged
turt2live merged 4 commits into
matrix-org:masterfrom
Half-Shot:hs/upload-limits
Sep 26, 2018
Merged

turt2live merged 4 commits into
matrix-org:masterfrom
Half-Shot:hs/upload-limits

Conversation

@Half-Shot

@Half-Shot Half-Shot commented May 3, 2018 •

Copy link
Copy Markdown
Contributor

@Half-Shot
Half-Shot force-pushed the hs/upload-limits branch from 6fe95d1 to 9596087 Compare May 3, 2018 16:58
Comment thread src/client.js Outdated
};

/**
* Get the room for the given room ID.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahem

Comment thread src/client.js Outdated
* @param {module:client.callback} callback Optional.
* @return {module:client.Promise} Resolves with an object containing the limits.
*/
MatrixClient.prototype.getMediaLimits = function(callback) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably just be getMediaRepoConfiguration or something, given the opportunity for future expansion.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+++1 for magic this super generic

@Half-Shot
Half-Shot requested a review from a team August 30, 2018 10:58
@Half-Shot

Copy link
Copy Markdown
Contributor Author

Aaaaaanyone? :(

@turt2live
turt2live merged commit 40f2a69 into matrix-org:master Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants