Repository navigation
Add tests for MSC3890: Remotely silence local notifications - #576
Merged
Merged
Conversation
This method allows for creating a new device under the same user. This is a bit of a hacky step towards supporting multiple devices for the same user (which Complement doesn't do yet).
Again, a bit of a hack to support logging out another device.
squahtx
reviewed
Jan 11, 2023
clokep
changed the title
This is much cleaner - thanks for the suggestion Sean!
squahtx
reviewed
Jan 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements tests for MSC3890. The server-side of this MSC is quite small: simply delete a bit of account data when a user's device is logged out/deleted.
I ran into some complications when writing this test. Complement doesn't make it easy to manipulate multiple devices of the same user at once (at least as far as I can tell). I created a helper method to log in to an existing user account in order to create another device. From there I did a bit of a hack to create another CSAPI client. I'd be interested if people know a better way to manipulate multiple devices of a single user in Complement, or have ideas on how to improve the status quo.cd70eb9 improves this substantially by adding aLoginUsermethod todeployment. See this test code for how this can be used to create new devices on an existing user.