Repository navigation
Add test to make sure we can paginate after getting remote event from timestamp to event endpoint - #406
Merged
MadLittleMods merged 3 commits intoJul 22, 2022
Conversation
Merged
4 of 5 tasks
…nt-fetched-v2 Conflicts: tests/msc3030_test.go
MadLittleMods
marked this pull request as ready for review
July 11, 2022 22:27
DMRobertson
approved these changes
Jul 12, 2022
DMRobertson
left a comment
DMRobertson
left a comment
Contributor
There was a problem hiding this comment.
Seems reasonable to me! I guess this needs to wait for the corresponding Synapse change though before merging?
kegsay
approved these changes
Jul 12, 2022
MadLittleMods
added a commit
to matrix-org/synapse
that referenced
this pull request
Jul 22, 2022
…ater (#13205) Depends on #13320 Complement tests: matrix-org/complement#406 We could use the same method to backfill for `/context` as well in the future, see #3848
MadLittleMods
deleted the
madlittlemods/msc3030-backfill-at-remote-event-fetched-v2
branch
July 22, 2022 21:01
Contributor
Author
|
Thanks for the review @DMRobertson and @kegsay 🐁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test to make sure we can paginate after getting remote event from timestamp to event endpoint
Synapse changes: matrix-org/synapse#13205