Repository navigation
Add a test for device list updates of local users coming down /sync - #305
Merged
Merged
Conversation
anoadragon453
force-pushed
the
anoa/local_device_list_update
branch
from
February 10, 2022 18:26
6f93abe to
49c62d0
Compare
anoadragon453
commented
Feb 10, 2022
anoadragon453
force-pushed
the
anoa/local_device_list_update
branch
from
February 10, 2022 18:37
49c62d0 to
1a8c6c1
Compare
kegsay
approved these changes
Feb 11, 2022
kegsay
left a comment
kegsay
left a comment
Member
There was a problem hiding this comment.
Use whoami and dendrite should be happier too.
Member
Author
|
Have updated, however it looks like Dendrite doesn't support the v3 version of the |
anoadragon453
marked this pull request as ready for review
February 15, 2022 11:35
Member
|
No, I'll just add v3 to Dendrite and merge this when it has landed, assuming you're happy. |
Member
Author
|
@kegsay Yep ok, sounds good to me! |
Member
|
This has taken a bit longer than planned because it's kinda annoying to actually do this using |
Member
|
Tests still failing because |
kegsay
added a commit
to matrix-org/dendrite
that referenced
this pull request
Feb 18, 2022
Basically include `is_guest` and `device_id`. The latter is needed for matrix-org/complement#305
kegsay
added a commit
to matrix-org/dendrite
that referenced
this pull request
Feb 18, 2022
Basically include `is_guest` and `device_id`. The latter is needed for matrix-org/complement#305
Member
|
Tests should pass now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test that: checks device list changes are propagated to other users on the local homeserver, if those users share a room.
This was created in part to help test matrix-org/synapse#11905, until I realised that we're going to need to reach deeper into Synapse in order to do what we want.
Still, this is hopefully useful.