Repository navigation
Conversation
clokep
marked this pull request as draft
June 10, 2021 11:36
clokep
marked this pull request as ready for review
June 11, 2021 13:42
richvdh
approved these changes
Jun 14, 2021
Member
|
Why hasn't this been merged? |
Member
Author
Because the corresponding Synapse PR needs changes and hasn't merged, so tests will fail if this is merged. |
clokep
changed the title
Member
Author
|
Per the Synapse PR I'm going to re-work this. It did partially land in #138. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates tests for matrix-org/synapse#10085.