fix: keep push-to-talk enabled when global hotkey fails#3
Open
UriZafrir wants to merge 1 commit into
Open
Conversation
When the global hotkey fails to initialize, the app was falling back to toggle mode (push_to_talk = false). Toggle mode is broken — it transitions states without creating a recorder or running transcription, causing the app to get stuck on 'Transcribing...'. Now the app keeps push_to_talk = true and just warns the user that the global hotkey is unavailable. Space key continues to work via terminal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the global hotkey fails to initialize on Linux (e.g., missing evdev permissions), the app silently falls back to toggle mode by setting
push_to_talk = false. Toggle mode is broken — it transitions states without creating a recorder or running transcription, causing the app to get stuck on "Transcribing...".Fixes #2
Change
Keep
push_to_talk = truewhen the global hotkey fails. The terminal keyboard (space) continues to work through the PTT path. Just warn the user the global hotkey is unavailable.Err(e) => { eprintln!("[voice] Warning: Could not set up global hotkey: {}", e); - if self.config.push_to_talk { - eprintln!("[voice] Falling back to toggle mode (press space to start/stop recording)."); - self.config.push_to_talk = false; - } + eprintln!("[voice] Global hotkey unavailable. Use terminal keyboard (space) to record."); }