Repository navigation
test(ssh): assert the fork ignores a t3 already on the remote PATH - #21
Merged
Merged
Conversation
`feat(fork): add independent update channel` dropped the `command -v t3` short-circuit from the remote runner script, because this fork ships its own server package and exec'ing whatever `t3` sits on the remote PATH would launch someone else's build. `tunnel.test.ts` pins that removal, but the process-level `existing-cli` case in `runnerProcess.test.ts` still asserted the upstream behavior. It went unnoticed until PR #17 gave the fork a CI gate that actually runs the suite, and it has been the only real failure in `Fork CI` since. Rather than delete the case, this turns it into a guard for the fork's own invariant. `bin/t3` is now a decoy that prints a different argv instead of a symlink to the installed CLI, so the assertions distinguish which binary ran, and the installer call is expected rather than forbidden. Re-adding the short-circuit to `tunnel.ts` fails the case with `expected [ 'path-cli' ] to deeply equal [ 'serve', 'a path with spaces' ]`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork CIhas been red onfork-mainsince the gate landed. The only real failure isremote runner install diagnostics > handles 'npx'/'existing-cli'and itsnpmtwin inpackages/ssh/src/runnerProcess.test.ts, expecting exit 0 and getting 1. The other three counts invp run: 4 failedare siblings the parallel run killed.The fork's
feat(fork): add independent update channelremoved thecommand -v t3short-circuit from the remote runner script inpackages/ssh/src/tunnel.ts. That removal is correct: this fork ships its own server package, and exec'ing whatevert3happens to sit on the remote PATH would launch someone else's build instead of the pinned one.tunnel.test.ts:115already asserts the shortcut is gone. The process-levelexisting-clicase was never updated, so it kept asserting upstream behavior. It stayed invisible until #17 gave the fork a CI gate that actually runs the suite.Rather than delete the case, this turns it into a guard for the fork's own invariant, renamed
ignores-path-cli.bin/t3becomes a decoy script printing a different argv instead of a symlink to the installed CLI, so the assertions can tell which binary ran, and the installer call is now expected rather than forbidden.Verification
All 19 tests in
packages/ssh/src/runnerProcess.test.tspass, andtsc --noEmiton the package is clean. To confirm the case is not passing for the wrong reason, I temporarily re-added the short-circuit totunnel.tsand it failed as intended:No production code changes;
tunnel.tsis untouched in this diff.Model: Claude Opus 5 (1M context), harness: Claude Code in T3 Code.
🤖 Generated with Claude Code