This repository was archived by the owner on Aug 8, 2023. It is now read-only.
Repository navigation
Current Scheduler - #9728
Merged
Merged
Current Scheduler#9728
Conversation
jfirebaugh
approved these changes
Aug 8, 2017
jfirebaugh
left a comment
jfirebaugh
left a comment
Contributor
There was a problem hiding this comment.
Grepping for RunLoop::Get shows some remaining usage that should be changed to Scheduler::Get: android/src/file_source.cpp, darwin/src/MGLOfflineStorage.mm, and the comment in scheduler.hpp that you updated in the combined PR. Looks good other than that.
- Adds a way to set the current scheduler on the thread to be used whenever a mailbox is created that needs to reply on this thread
ivovandongen
force-pushed
the
ivd-current-scheduler-cleaned
branch
from
August 9, 2017 08:32
b590a7f to
6b44fb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted the current
Schedulerpart of #9611 as requested:This PR adds an abstraction on top of the RunLoop so that we can Schedule work on arbitrary schedulers. This is important for asynchronous rendering where we are dealing with threads without a runloop that need to defer scheduling of additional work to another thread scheduler and/or use another form of scheduling than a RunLoop (see #9576).
In certain places we will still work with the
RunLoopdirectly where it's needed (OnlineFileSource,AsyncTask)