This repository was archived by the owner on Aug 8, 2023. It is now read-only.
Repository navigation
Annotation symbols should ignore icon placement - #6629
Merged
brunoabinader merged 2 commits intoOct 11, 2016
Merged
Conversation
|
@brunoabinader, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jfirebaugh, @ansis and @boundsj to be potential reviewers. |
Contributor
|
Setting |
Contributor
Author
In This means these features are always visible and can bypass the placement scale check. |
brunoabinader
force-pushed
the
6629-symbol-annotation-ignore-icon-placement
branch
from
October 9, 2016 10:49
6e74461 to
d440c56
Compare
Contributor
Author
|
Addressed @jfirebaugh review comments. |
jfirebaugh
approved these changes
Oct 10, 2016
brunoabinader
force-pushed
the
6629-symbol-annotation-ignore-icon-placement
branch
from
October 11, 2016 06:55
d440c56 to
efc1bff
Compare
brunoabinader
deleted the
6629-symbol-annotation-ignore-icon-placement
branch
October 11, 2016 07:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently set
icon-allow-overlaptotruewhen creating the annotation symbol layer but we also needicon-ignore-placementset totrue.Ignoring icon placements causes symbol annotations to skip calculating the placement scale - which is currently broken (see #6628) and thus returning the correct values for rendered features.