Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Map::setLatLng differs from Map::setLatLngZoom if zoom is same - #6625

Merged
brunoabinader merged 1 commit into
masterfrom
6625-map-setlatlng-bugfix
Oct 7, 2016
Merged

brunoabinader merged 1 commit into
masterfrom
6625-map-setlatlng-bugfix

Conversation

@brunoabinader

@brunoabinader brunoabinader commented Oct 7, 2016 •

Copy link
Copy Markdown
Contributor

These calls should produce the same results:

double zoom = 0;
LatLng latLng { 1, 1 };

// call 1
mbgl::Map::setZoom(zoom);
mbgl::Map::setLatLng(latLng);

// call 2
mbgl::map::setLatLngZoom(latLng, zoom);

Previously part of #6553.

@brunoabinader brunoabinader added bug Core The cross-platform C++ core, aka mbgl labels Oct 7, 2016
We were erroneously assigning a value to optional<ScreenCoordinate>
(null island), causing it to be a valid anchor for Transform::easeTo.
@mention-bot

Copy link
Copy Markdown

@brunoabinader, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jfirebaugh, @kkaefer and @tmpsantos to be potential reviewers.

@brunoabinader
brunoabinader merged commit 3b8b68d into master Oct 7, 2016
@brunoabinader
brunoabinader deleted the 6625-map-setlatlng-bugfix branch October 7, 2016 14:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Core The cross-platform C++ core, aka mbgl

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants