Repository navigation
Conversation
| float gammaScale = 1.0f; | ||
|
|
||
| if (alignedWithMap) { | ||
| if (false && alignedWithMap) { |
There was a problem hiding this comment.
I'll fix this, was poking but this whole codepath can be dropped.
1ec5
added
feature
navigation
|
Good stuff @yhahn! Do you know if this affects the recently added
|
7ec107d to
e91dba9
Compare
… inheritance for this value from text-rotation-alignment
0f13843 to
756d83b
Compare
yhahn
changed the title
|
@jfirebaugh 🙏 ready for your review when you have a chance : ) |
| var parseCSSColor = require('csscolorparser').parseCSSColor; | ||
|
|
||
| global.camelize = function (str) { | ||
| str = str === undefined ? 'undefined' : str; |
There was a problem hiding this comment.
What prompted this change, and the corresponding one in camelizeWithLeadingLowercase?
There was a problem hiding this comment.
This was to have Undefined be the value for text-pitch-alignment when it's not defined in the style and be able to detect when inheritance should kick in (per mapbox/mapbox-gl-style-spec#460 (comment)).
It's definitely the main eyebrow-raiser in this PR 😄 would love to know if there's a better way to achieve this.
There was a problem hiding this comment.
Yeah, I see the AlignmentType::Undefined value. Why does a JS undefined value pass through camelize though?
|
👌 |
4 participants
Native port of mapbox/mapbox-gl-js#2668.
Backlog
cc @lucaswoj @jfirebaugh @mollymerp @lxbarth