Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Don't store asset:// requests in the cache - #3477

Merged
kkaefer merged 2 commits into
masterfrom
3477-dont-cache-assets
Jan 8, 2016
Merged

kkaefer merged 2 commits into
masterfrom
3477-dont-cache-assets

Conversation

@kkaefer

@kkaefer kkaefer commented Jan 8, 2016

Copy link
Copy Markdown
Member

We're currently storing asset:// requests in the cache, but given that they're on the local file system anyway, we should never do that.

@kkaefer kkaefer self-assigned this Jan 8, 2016
@kkaefer
kkaefer merged commit 4479f5d into master Jan 8, 2016
@kkaefer
kkaefer deleted the 3477-dont-cache-assets branch January 8, 2016 12:21
@jfirebaugh

Copy link
Copy Markdown
Contributor

👍

Support for asset:// URLs is another thing I can imagine moving into OfflineFileSource. Logically, they are an offline resource, and the fact that OnlineFileSource must handle them differently suggests that they shouldn't be its responsibility.

@kkaefer

kkaefer commented Jan 8, 2016

Copy link
Copy Markdown
Member Author

Yeah, agreed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants