Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Update libuv to 1.7.5 - #2609

Closed
mikemorris wants to merge 0 commit into
masterfrom
update-libuv
Closed

Update libuv to 1.7.5#2609
mikemorris wants to merge 0 commit into
masterfrom
update-libuv

Conversation

@mikemorris

Copy link
Copy Markdown
Contributor

Update from ancient v0.10.28 across all platforms, but retain support for older versions.

/cc @kkaefer

@mikemorris mikemorris added iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS Android Mapbox Maps SDK for Android Linux labels Oct 13, 2015
@kkaefer

kkaefer commented Oct 14, 2015

Copy link
Copy Markdown
Member

Looks great! Thanks for rolling this PR!

@mikemorris mikemorris closed this Oct 14, 2015
@mikemorris
mikemorris deleted the update-libuv branch October 14, 2015 15:38
@mikemorris

Copy link
Copy Markdown
Contributor Author

Screwed up the -ff-only merge by pushing master first, then force-pushing update-libuv.
This pull request contained the following commits:

@picciano

Copy link
Copy Markdown

Is this update to address some of the crashing we are seeing? Such as #2417 ?

@mikemorris

Copy link
Copy Markdown
Contributor Author

Motivated more by simply wanting to move off of an ancient version of libuv, I'd be curious to know if this does anything to address #2417 though. If not, the bug is likely in mbgl::HTTPNSURLRequest::handleResult() as @1ec5 mentioned.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Android Mapbox Maps SDK for Android iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants