Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

fixes #2044: add -showAnnotations:animated: - #2050

Merged
incanus merged 1 commit into
masterfrom
show-annotations
Aug 12, 2015
Merged

incanus merged 1 commit into
masterfrom
show-annotations

Conversation

@incanus

@incanus incanus commented Aug 12, 2015

Copy link
Copy Markdown
Contributor

No description provided.

@incanus incanus added feature iOS Mapbox Maps SDK for iOS in progress labels Aug 12, 2015
@incanus

incanus commented Aug 12, 2015

Copy link
Copy Markdown
Contributor Author

Want to give it a spin @jncn?

@incanus incanus added GL JS parity For feature parity with Mapbox GL JS and removed feature labels Aug 12, 2015
@incanus

incanus commented Aug 12, 2015

Copy link
Copy Markdown
Contributor Author

We decided there may be some more subtlety in MapKit's implementation than a flat 100px all around (something to do with map aspect ratio and/or the poles), but this is a good first cut.

@incanus

incanus commented Aug 12, 2015

Copy link
Copy Markdown
Contributor Author

Also we may want to do something with view controller layout guides using -[UILayoutSupport length] and the current meters/pixel, but again, we can iterate later.

@incanus
incanus merged commit 772238a into master Aug 12, 2015
@incanus
incanus deleted the show-annotations branch August 12, 2015 22:15
@jncn

jncn commented Aug 13, 2015

Copy link
Copy Markdown

Great! It does the job, thanks. Might indeed need some refinements. MapKit's counterpart isn't perfect either, btw.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

GL JS parity For feature parity with Mapbox GL JS iOS Mapbox Maps SDK for iOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants