This repository was archived by the owner on Aug 8, 2023. It is now read-only.
Go dormant before termination - #1805
Merged
Merged
Conversation
Speculative fix for #1460 per #1460 (comment).
Contributor
Author
|
@picciano @mb12 @robipresotto, feel free to take these changes for a spin. Hopefully we can get these mystery crashes to stop mucking up everyone’s analytics! 👊→🌳 |
|
#1509 consistently reproducible. I have added steps to reproduce it in the issue itself. |
Contributor
Author
|
@mb12, ah, that’s the alpha transparency one. Got a little ahead of myself. |
This was referenced Jul 1, 2015
Closed
Contributor
Author
|
Another attempt in #1821. |
Contributor
|
Should we roll this back just to simplify a bit? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a speculative fix for #1460,
#1509, and #1680 per #1460 (comment), building off the work in #1451. Once we getUIApplicationWillTerminateNotification, it’s unlikely that there will be any need to service further requests for rendering, programmatic viewport manipulation, or gesture recognition.I’ll keep an eye on our HockeyApp stats to see if #1460 goes away at least.
/cc @incanus @friedbunny