Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Improve behavior on getting error 404 during offline regions loading - #16240

Merged
pozdnyakov merged 4 commits into
masterfrom
mikhail_offline_tool_404_error_handling
Feb 28, 2020
Merged

pozdnyakov merged 4 commits into
masterfrom
mikhail_offline_tool_404_error_handling

Conversation

@pozdnyakov

Copy link
Copy Markdown
Contributor

If error 404 turns up during offline regions loading, the behavior is changed in the following way:

  • Offline download does not hang
  • The error message contains URL protocol and host

Fixes https://github.com/mapbox/mapbox-gl-native-team/issues/186
Fixes #15819
Fixes #15932

@pozdnyakov pozdnyakov added offline Core The cross-platform C++ core, aka mbgl labels Feb 27, 2020
@pozdnyakov pozdnyakov self-assigned this Feb 27, 2020
@pozdnyakov
pozdnyakov marked this pull request as ready for review February 27, 2020 13:43
Comment thread platform/default/src/mbgl/storage/http_file_source.cpp Outdated
@pozdnyakov
pozdnyakov force-pushed the mikhail_offline_tool_404_error_handling branch 2 times, most recently from 2f3813f to f8cc697 Compare February 28, 2020 09:09
@pozdnyakov
pozdnyakov force-pushed the mikhail_offline_tool_404_error_handling branch from f8cc697 to 8f3295b Compare February 28, 2020 10:11
@pozdnyakov
pozdnyakov merged commit 517f780 into master Feb 28, 2020
@pozdnyakov
pozdnyakov deleted the mikhail_offline_tool_404_error_handling branch February 28, 2020 10:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Core The cross-platform C++ core, aka mbgl offline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mbgl-offline should not hang when there's a 404/401 Add resource URL to errors in mbgl-offline script

2 participants