This repository was archived by the owner on Aug 8, 2023. It is now read-only.
[tile mode] Improvements in symbol placement on tile borders - #16159
Merged
Merged
Conversation
pozdnyakov
added
bug
text rendering
Core
pozdnyakov
marked this pull request as ready for review
January 31, 2020 13:56
alexshalamov
approved these changes
Jan 31, 2020
pozdnyakov
force-pushed
the
mikhail_tile_mode_placement_fixes
branch
from
February 3, 2020 18:26
ce3370f to
a0d69b4
Compare
This change fixes the following problems: 1) Before this change, when multiple symbols were grouped close to the tile borders, different tiles could place different symbols, because each tile arbitrary assigned feature ids, and these ids defined the placement order being applied. This caused artifacts at the tile boundaries. With this change, in tile mode the placement order of two symbols crossing a tile border is defined by their anchor `y` values. It means that the symbols are being placed the same order across all the tiles. 2) Before this change, the engine did not place with priority the symbols crossing the borders between two neighboring tiles. Now it does, and it improves a lot symbol placement stability in the tile map mode.
pozdnyakov
force-pushed
the
mikhail_tile_mode_placement_fixes
branch
from
February 3, 2020 18:27
a0d69b4 to
4ca9e6a
Compare
This was referenced Feb 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes the following problems:
Before this change, when multiple symbols were grouped close to the
tile borders, different tiles could place different symbols, because each
tile arbitrary assigned feature ids, and these ids defined the placement
order being applied. This caused artifacts at the tile boundaries.
With this change, in tile mode the placement order of two symbols crossing
a tile border is defined by their anchor
yvalues. It means that thesymbols are being placed the same order across all the tiles.
Before this change, the engine did not place with priority the symbols
crossing the borders between two neighboring tiles. Now it does, and it
improves a lot symbol placement stability in the tile map mode.
Fixes https://github.com/mapbox/mapbox-gl-native-team/issues/168