Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

[test] iOS unit test runner - #16158

Merged
jmalanen merged 9 commits into
masterfrom
jmalanen-ios-test
Feb 14, 2020
Merged

[test] iOS unit test runner#16158
jmalanen merged 9 commits into
masterfrom
jmalanen-ios-test

Conversation

@jmalanen

@jmalanen jmalanen commented Jan 31, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR also includes other improvements:

  • Share common code between test runners (render, unit and benchmark)
  • Enable ccache for iOS builds (reduces build times from 10 minutes to < 1 minute)
  • Fix the CPU core count for macOS builds
  • Change ios-xcode11-release build to use template and change the target arch from simulator to iPhone/arm64e
  • Bump minimum iOS version from 9.0 to 12.0

Fixes: mapbox/mapbox-gl-native-team#172

@jmalanen
jmalanen force-pushed the jmalanen-ios-test branch 19 times, most recently from c13d420 to 8c58883 Compare February 5, 2020 17:21
@jmalanen
jmalanen force-pushed the jmalanen-ios-test branch 11 times, most recently from 981f1f9 to 1784540 Compare February 10, 2020 13:08
@jmalanen jmalanen self-assigned this Feb 12, 2020
zmiao
zmiao reviewed Feb 12, 2020
View reviewed changes
Comment thread test/ios/ios_test_runner.cpp Outdated
Comment thread platform/ios/ios.cmake Outdated
alexshalamov
alexshalamov reviewed Feb 12, 2020
View reviewed changes
Comment thread test/ios/Info.plist
Comment thread test/ios/ios_test_runner.cpp Outdated
Comment thread test/ios/iosTestRunner.mm Outdated
Comment thread test/ios/iosTestRunner.mm
@jmalanen
jmalanen force-pushed the jmalanen-ios-test branch 3 times, most recently from 47c85ed to 314b2a2 Compare February 13, 2020 13:28
zmiao
zmiao approved these changes Feb 13, 2020
View reviewed changes

@zmiao zmiao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This was referenced Feb 27, 2020
Merged
Closed
Merged
1ec5
1ec5 reviewed Feb 28, 2020
View reviewed changes
Comment thread platform/ios/ios.cmake

if(NOT DEFINED IOS_DEPLOYMENT_TARGET)
set(IOS_DEPLOYMENT_TARGET "9.0")
set(IOS_DEPLOYMENT_TARGET "12.0")

@1ec5 1ec5 Feb 28, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#16242 reverts this change.

This was referenced Mar 7, 2020
Merged
Merged
1ec5
1ec5 reviewed Mar 10, 2020
View reviewed changes
Comment thread CMakeLists.txt
project("Mapbox GL Native" LANGUAGES CXX C)

find_program(CCACHE_PROGRAM ccache)
if(CCACHE_PROGRAM AND CMAKE_SYSTEM_NAME STREQUAL "iOS")

@1ec5 1ec5 Mar 10, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#16289 disables ccache on iOS.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tmpsantos tmpsantos Awaiting requested review from tmpsantos
@pozdnyakov pozdnyakov Awaiting requested review from pozdnyakov
3 more reviewers
@1ec5 1ec5 1ec5 left review comments
@alexshalamov alexshalamov alexshalamov approved these changes
@zmiao zmiao zmiao approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jmalanen jmalanen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jmalanen @alexshalamov @1ec5 @zmiao