This repository was archived by the owner on Aug 8, 2023. It is now read-only.
[core] Do not try to place a center anchor beyond the center of the line - #15177
Merged
Merged
Conversation
alexshalamov
approved these changes
Jul 19, 2019
alexshalamov
left a comment
alexshalamov
left a comment
Contributor
There was a problem hiding this comment.
lgtm
looks like gl-gs master has few *-sort-key features landed, should be disabled for gl-native util backported.
pozdnyakov
reviewed
Jul 19, 2019
tmpsantos
force-pushed
the
tmpsantos-label_wrapping_center_anchor
branch
from
July 19, 2019 12:13
9aa237e to
c105939
Compare
Once the algorithm finds the center of the line, if placement is not possible, do not place the anchor. Previous code was trying to continue place the label beyond the center of the segment. Fixes #15139.
tmpsantos
force-pushed
the
tmpsantos-label_wrapping_center_anchor
branch
2 times, most recently
from
July 19, 2019 12:29
454bd27 to
ea38006
Compare
tmpsantos
force-pushed
the
tmpsantos-label_wrapping_center_anchor
branch
from
July 19, 2019 12:43
ea38006 to
7eea0ce
Compare
friedbunny
added
the
needs changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once the algorithm finds the center of the line, if placement is not possible, do not place the anchor.
Previous code was trying to continue place the label beyond the center of the segment. This aligns the behavior with GL JS.
Fixes #15139.