This repository was archived by the owner on Aug 8, 2023. It is now read-only.
[core] Port 'is-supported-script' expression to native - #11785
Merged
Conversation
anandthakker
approved these changes
Apr 27, 2018
anandthakker
left a comment
anandthakker
left a comment
Contributor
There was a problem hiding this comment.
I re-enabled the render tests but not the GL JS expression test because that test assumes the expression will always return true when run without a rendering context. We could write native-specific expression tests, but the render tests already cover the same functionality.
^ Maybe we should change the ignores.json description for the expression tests, so we're not confused in the future by their pointing to a closed issue.
Native port is much simpler because RTL text support is always enabled.
ChrisLoer
force-pushed
the
port-supported-script
branch
from
April 27, 2018 21:19
aec1db3 to
ede70d5
Compare
Contributor
Author
Good idea, made that change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11693.
Native port is much simpler because RTL text support is always enabled.
I re-enabled the render tests but not the GL JS expression test because that test assumes the expression will always return true when run without a rendering context. We could write native-specific expression tests, but the render tests already cover the same functionality.
/cc @anandthakker @nickidlugash