Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

[core] Only run placement for first layer per SymbolBucket - #11775

Merged
ChrisLoer merged 1 commit into
masterfrom
cloer-11764
May 3, 2018
Merged

ChrisLoer merged 1 commit into
masterfrom
cloer-11764

Conversation

@ChrisLoer

Copy link
Copy Markdown
Contributor

Native version of mapbox/mapbox-gl-js#6548.
Port of mapbox/mapbox-gl-js#6550.
Prevents symbols that share the same layout properties from colliding against each other.

Fixes issue #11764.

Bump GL JS pin to get regression test.
Rename "bucketName" -> "bucketLeaderID" to make it clearer what it represents.

/cc @ansis @jfirebaugh @ryanbaumann

@ChrisLoer
ChrisLoer requested a review from ansis April 25, 2018 22:41
@ChrisLoer ChrisLoer changed the title Only run placement for first layer per SymbolBucket [core] Only run placement for first layer per SymbolBucket Apr 25, 2018
Native version of mapbox/mapbox-gl-js#6548.
Port of mapbox/mapbox-gl-js#6550.
Prevents symbols that share the same layout properties from colliding against each other.

Bump GL JS pin to get regression test.
Rename "bucketName" -> "bucketLeaderID" to make it clearer what it represents.

@ansis ansis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ChrisLoer
ChrisLoer merged commit 27b2136 into master May 3, 2018
@jfirebaugh
jfirebaugh deleted the cloer-11764 branch July 27, 2018 22:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants