This repository was archived by the owner on Aug 8, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Aug 8, 2023. It is now read-only.
Use GridIndex instead of boost rtree for symbol placement. #8915
Description
Platform:
All
Mapbox SDK version:
Master
Steps to trigger behavior
GL Native is still using rtree for symbol placement. We should switch to GridIndex instead of rtree since its much faster spatial index than rtree. GL JS uses GridIndex for symbol placement.
Expected behavior
All references to boost rtree should be removed.
Actual behavior
rtree is still being used in performance critical symbol placement code.
Activity
jfirebaugh commentedon May 11, 2017
For reference, here's the gl-js commit making the switch (detailed rationale in the commit comment): mapbox/mapbox-gl-js@b62895a
ChrisLoer commentedon Oct 20, 2017
#10103 currently uses rtree for the new collision detection work, but the speed of the index will become even more performance critical, so we will probably end up looking more closely at whether rtree still makes sense.
/cc @ansis
ChrisLoer commentedon Nov 16, 2017
PR #10436 (merging soon) switches from rtree to GridIndex. We never actually profiled rtree vs GridIndex in isolation.