Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Data-driven runtime styling for Node #8495

Closed

Description

@1ec5

Basic runtime styling support was added to the Node module in #5318, but it doesn’t include property functions, which were implemented in mbgl in #7372. Currently, you can set property functions via style JSON. This issue tracks adding a way to manipulate them via the runtime styling API.

/cc @kkaefer @bsudekum

Activity

  1. jfirebaugh commented on Mar 22, 2017

    @jfirebaugh
    Contributor

    Can you say more specifically what you see as missing? The existing bindings pass most of the tests in https://github.com/mapbox/mapbox-gl-js/tree/master/test/integration/render-tests/runtime-styling, which include tests that use property functions.

  2. 1ec5 commented on Mar 22, 2017

    @1ec5
    ContributorAuthor

    @jfirebaugh, I was referring to passing property functions into setPaintProperty() from the JavaScript side, going off the discussion in #7372 (comment). From a cursory look at node_map.cpp, it didn’t look like there was support for property functions, but if there’s conversion magic going on, we can close this ticket and call it done. 😄

  3. jfirebaugh commented on Mar 22, 2017

    @jfirebaugh
    Contributor

    Yep, that should work -- it's handled by the logic in style/conversion/function.hpp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions