Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Feature querying should return existing annotations #6178

Closed

Description

@1ec5

When the feature querying API detects a feature in an annotation layer, it should somehow return the MGLAnnotation object that the feature represents – that is, the same MGLAnnotation object that was added to the map to place the feature on the map.

/cc @boundsj

Activity

  1. added
    iOSMapbox Maps SDK for iOS
    macOSMapbox Maps SDK for macOS
    annotationsAnnotations on iOS and macOS or markers on Android
    on Aug 26, 2016
  2. 1ec5 commented on Feb 13, 2017

    @1ec5
    ContributorAuthor

    In particular, the returned feature must not be tiled. Otherwise, the developer will immediately run into a roadblock: #6538.

  3. friedbunny commented on Jul 18, 2017

    @friedbunny
    Contributor

    This also includes annotations that happened to conform to MGLFeature — the additional identifier and attributes properties will not be persisted if such an object is added as an annotation.

    To make full use of MGLFeature-conforming annotations, instead add them to the map using the runtime styling API.

  4. 1ec5 commented on Jul 19, 2017

    @1ec5
    ContributorAuthor

    This also includes annotations that happened to conform to MGLFeature — the additional identifier and attributes properties will not be persisted if such an object is added as an annotation.

    This will become apparent to the developer at compile time once we fix #7454.

  5. stale commented on Dec 1, 2018

    @stale

    This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

  6. 1ec5 commented on Mar 8, 2019

    @1ec5
    ContributorAuthor

    Still needed as a prerequisite for #6181.

  7. reopened this on Mar 8, 2019
  8. removed
    archivedArchived because of inactivity
    on Mar 8, 2019
  9. stale commented on Sep 4, 2019

    @stale

    This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

  10. removed
    archivedArchived because of inactivity
    on Sep 5, 2019
  11. stale commented on May 22, 2020

    @stale

    This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    annotationsAnnotations on iOS and macOS or markers on AndroidarchivedArchived because of inactivitybuggl-iosiOSMapbox Maps SDK for iOSmacOSMapbox Maps SDK for macOS

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions