Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

collision debug doesn't work reliably #5055

Closed

Description

@jfirebaugh

Turning on collision debug option results in some tiles showing it and other tiles not showing it. As you pan and zoom, it turns on and off on a tile-by-tile basis unpredictably.

Activity

  1. brunoabinader commented on Oct 7, 2016

    @brunoabinader
    Contributor

    I've noticed that debug collisions are rendered as expected when using a style with raster layer only:
    screen shot 2016-10-07 at 6 21 37 pm

    However, debug collisions are only rendered on the tiles appearing on the bottom right corner for the examples below:
    screen shot 2016-10-07 at 6 21 31 pm
    screen shot 2016-10-07 at 6 21 45 pm

  2. brunoabinader commented on Oct 7, 2016

    @brunoabinader
    Contributor

    Given the examples above, my suspicion is that somehow the tile size affects the way how the collision debug is rendered.

  3. brunoabinader commented on Oct 11, 2016

    @brunoabinader
    Contributor

    Given the examples above, my suspicion is that somehow the tile size affects the way how the collision debug is rendered.

    Even though we don't always enable stencil test when rendering symbols, we do render collision using the same stencil function. This gets updated on each render call, but only if the bucket needs clipping.

    In the cases above, the render result was unpredictable because it used the last stencil function set by the previous bucket that needed clipping.

  4. jfirebaugh commented on Oct 11, 2016

    @jfirebaugh
    ContributorAuthor

    Thanks for investigating!

    In the cases above, the render result was unpredictable because it used the last stencil function set by the previous bucket that needed clipping.

    This means it's a good example of a bug that will be fixed by #6468.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions