Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Annotations don't maintain size during tilting #2186

Description

@friedbunny

When the map is tilted, marker annotations are scaled with the rest of the map — markers closer to the horizon are small and difficult to interact with.

We should provide an option (default: on) for annotations to maintain their normal scale during tilting.

simulator screen shot aug 26 2015 4 47 13 pm

/cc @ansis @incanus @1ec5

Activity

  1. incanus commented on Aug 27, 2015

    @incanus
    Contributor

    This is especially jarring considering the wide range of sizes that can happen.

    img_4133

  2. ansis commented on Aug 27, 2015

    @ansis
    Contributor

    Yeah, it's not just annotations. Road and poi labels become illegible near the top. Nothing works well when the map is tilted this steep. The roads become so narrow they disappear. Steep tilt is a completely different game. Many things (rendering, data loading, styling, labeling) need to be different. I think this will be a lot of work so I'm not sure how soon we'll have it.

    We can also tweak the altitude parameter to make the maps less perspectivey. If altitude is higher than the map can be squished more in the y direction without making close things appear bigger.

    What's the use case here? Why is the map in perspective mode and why do annotations need to be equally prominent in this case?

    Does it matter that it's harder to interact? Can the user just pan the map forward to make things at the back bigger? (this will be easier with #2139 (comment))

    Does the hit detection need to be adjusted for perspective views?

  3. mb12 commented on Aug 27, 2015

    @mb12

    In Nokia maps, Google Maps and Apple maps, the user can drop a pin (annotation) anywhere on the map. The application then does an object query and shows whats at that point (address etc.). This user pin retains its original size/shape when the map is panned with perspective enabled (This may very well be an artifact of how pins/annotations are implemented in these applications and not an intentional feature).

  4. incanus commented on Aug 27, 2015

    @incanus
    Contributor

    What @mb12 said — all mobile toolkits maintain size for markers. This affects hit detection as well as popup/callout placement.

    The use case is general tilt for interactive maps just like other frameworks. Once you've got tilt, users expect it to work the same way.

  5. friedbunny commented on Aug 27, 2015

    @friedbunny
    ContributorAuthor

    Aye, parity is the main reason — having the option to perspective-scale markers is cool, though.

  6. incanus commented on Aug 27, 2015

    @incanus
    Contributor

    Per voice, this sounds like a fairly heavy lift since it would "undoing" the sizing for certain symbols and not necessarily just not executing a current routine. It also has collision implications.

    We can also play with the altitude to see how it affects the steepness of the angle.

  7. friedbunny commented on Sep 11, 2015

    @friedbunny
    ContributorAuthor

    The user location annotation's accuracy circle now has the opposite problem: it should maintain scale as the map is vertically panned, but it instead maintains a constant size... which means it's inaccurate everywhere on the tilted screen except in the center.

    The user location annotation is a native UIView and will need a separate-but-related fix to our GL-implemented marker annotations.

  8. changed the title [-]Marker annotations don't maintain size during tilting[/-] [+]Annotations don't maintain size during tilting[/+] on Oct 2, 2015
  9. 1ec5 commented on May 14, 2016

    @1ec5
    Contributor

    #5040 asks for the opposite behavior with respect to the user dot and other annotation views.

  10. added
    annotationsAnnotations on iOS and macOS or markers on Android
    on May 24, 2016
  11. added
    MapKit parityFor feature parity with MapKit on iOS or macOS
    and removed
    GL JS parityFor feature parity with Mapbox GL JS
    on Aug 15, 2016
  12. 1 remaining item

  13. 1ec5 commented on Jun 30, 2017

    @1ec5
    Contributor

    #9009 will unblock this work at the mbgl level.

  14. stale commented on Nov 30, 2018

    @stale

    This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

  15. removed
    archivedArchived because of inactivity
    on Dec 3, 2018
  16. stale commented on Jun 2, 2019

    @stale

    This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

  17. removed
    archivedArchived because of inactivity
    on Jun 3, 2019
  18. stale commented on Nov 30, 2019

    @stale

    This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    CoreThe cross-platform C++ core, aka mbglMapKit parityFor feature parity with MapKit on iOS or macOSannotationsAnnotations on iOS and macOS or markers on AndroidarchivedArchived because of inactivityrendering

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions