Add sort key api for FillLayer and LineLayer - #209
Conversation
tobrun
left a comment
tobrun
left a comment
There was a problem hiding this comment.
Did you generate these files? or manually wrote them?
|
@tobrun I manually write them. Is there any method to generate them? |
|
Our Layer and paint/layout property API is fully generated from the style-specification. The version of the style specification comes from the mapbox-gl-js submodule within mapbox-gl-native. These properties will be automatically supported once we update to the new style spec version and we have reran the command to generate new code. I created a small task for you to start looking into how this code generator works in #212. Let me know if you need more information! |
Chaoba
changed the title
Chaoba
changed the title
68fc21f to
d6cf174
Compare
d6cf174 to
a081a28
Compare
|
|
||
| writeIfModified(`vendor/mapbox-gl-native/platform/android/src/style/layers/${layerFileName}_layer.hpp`, layerHpp(layer)); | ||
| writeIfModified(`vendor/mapbox-gl-native/platform/android/src/style/layers/${layerFileName}_layer.cpp`, layerCpp(layer)); | ||
| } |
There was a problem hiding this comment.
👍 should this jni generator run on the gl-native side? I think it also make sense to add it here, because we are going to migrate the jni code to this repo. Currently we need one extra step to commit this change in the gl-native submodule.
cc @tobrun
3 participants
Resolves #212
This pr add sort key api for Filllayer and Lilllayer, part of #197
The jni binding pr: https://github.com/mapbox/mapbox-gl-native/pull/16256/files