Skip to content

Edit convert functions to output linear interpolation - #9076

Closed
Jo-IE wants to merge 1 commit into
mapbox:masterfrom
Jo-IE:outputlinearinterpolation
Closed

Jo-IE wants to merge 1 commit into
mapbox:masterfrom
Jo-IE:outputlinearinterpolation

Conversation

@Jo-IE

@Jo-IE Jo-IE commented Dec 5, 2019

Copy link
Copy Markdown
Contributor

This PR closes #6840. I edited the convertPropertyFunction and the convertZoomFunction to output linear interpolations when base is 1.

I also ran yarn lint --fix locally to fix linting errors. I am also getting some JSDocs warnings after running yarn lint --fix.

@arindam1993

Copy link
Copy Markdown
Contributor

Hey @Jo-IE 👋 , thanks a lot for your contribution! Much appreciated!

I think your logic is good overall, but could you please make your change without having run yarn lint --fix? The extra diffs are making the change hard to understand with the extra new-lines.

I'd recommend running yarn run lint only and fixing only the errors manually.

@Jo-IE

Jo-IE commented Dec 13, 2019

Copy link
Copy Markdown
Contributor Author

Thank you @arindam1993! I will make those adjustments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expressions convert functions: output linear interpolation?

2 participants